Benjamin Otte [Fri, 6 Sep 2013 01:01:37 +0000 (03:01 +0200)]
css: Change currentColor handling
We now pass NULL when the current color should be the default value of
the "color" property and we haven't looked up any value yet. This way we
don't need to look it up all the time and more importantly we can
resolve the default color, which is required because it's a
GtkCssColorValue and not a GtkCssRgbaValue.
Fixes assertions triggering at Polari startup.
Benjamin Otte [Fri, 6 Sep 2013 01:01:10 +0000 (03:01 +0200)]
cssimage: Remove unused variables
Matthias Clasen [Thu, 5 Sep 2013 22:50:23 +0000 (18:50 -0400)]
Don't use deprecated GSimpleActionGroup api
Instead, use the corresponding GActionMap api.
Matthias Clasen [Thu, 5 Sep 2013 22:45:16 +0000 (18:45 -0400)]
Don't call deprecated combobox api
gtk_combo_box_set_title is not needed anymore, since we
dropped the tearoff support.
Behdad Esfahbod [Thu, 5 Sep 2013 22:42:45 +0000 (18:42 -0400)]
[gdkcairo] Fix color premultiplication
https://bugzilla.gnome.org/show_bug.cgi?id=513812
Alexander Larsson [Thu, 5 Sep 2013 17:30:23 +0000 (19:30 +0200)]
Sync with changes in the cairo device-scale handling
The version of device scale that landed in upstream cairo
master already inherits the device scale in cairo_create_similar,
so no need to do that in gtk anymore.
Benjamin Otte [Thu, 5 Sep 2013 16:47:29 +0000 (18:47 +0200)]
reftests: Add a reftest for the cell renderer fix
The reftest is a bit flaky because it compares cell renderers with
GtkImage and therefor an icon view with a GtkBox, but it's the best I
can come up with.
https://bugzilla.gnome.org/show_bug.cgi?id=702423
Benjamin Otte [Thu, 5 Sep 2013 16:45:13 +0000 (18:45 +0200)]
cellrendererpixbuf: Don't eat states
Even when not following states, blacklist the states we don't follow
instead of whitelisting the ones we do. This way, we don't accidentally
eat new ones like the text direction flags.
Fixes a bug where text direction wasn't available when rendering stock
items.
https://bugzilla.gnome.org/show_bug.cgi?id=702423
Benjamin Otte [Thu, 5 Sep 2013 16:42:53 +0000 (18:42 +0200)]
cellrendererpixbuf: Follow state even when insensitive
Benjamin Otte [Thu, 5 Sep 2013 14:26:46 +0000 (16:26 +0200)]
cellrendererpixbuf: Always follow state
... not just in PRELIT | SELECTED.
Piotr Drąg [Thu, 5 Sep 2013 12:40:56 +0000 (14:40 +0200)]
Updated Polish translation
Daniel Mustieles [Thu, 5 Sep 2013 09:17:52 +0000 (11:17 +0200)]
Updated Spanish translation
Milo Casagrande [Thu, 5 Sep 2013 08:41:57 +0000 (10:41 +0200)]
[l10n] Updated Italian translation.
Chun-wei Fan [Thu, 5 Sep 2013 06:33:22 +0000 (14:33 +0800)]
Visual C++ Builds: Fix "install" Projects
Due to the split up of the property sheets, the install projects did not
have info on the Intermediate and Output Paths, which caused confusing
messages from Visual Studio to show up upon completing build+"install" and
closing Visual Studio on whether to reload the install project, at least on
Visual Studio 2008.
Also clean up the Visual Studio 2008 install project a bit.
Include the property sheet which defines these properties to fix this.
Matthias Clasen [Thu, 5 Sep 2013 00:59:56 +0000 (20:59 -0400)]
Trivial formatting fixes
Jiro Matsuzawa [Wed, 4 Sep 2013 16:39:16 +0000 (01:39 +0900)]
Fix a typo in an error message
https://bugzilla.gnome.org/show_bug.cgi?id=707488
Alexander Larsson [Wed, 4 Sep 2013 19:00:23 +0000 (21:00 +0200)]
GtkListBox: ref_sink new object in set_header and set_adjustment
These are taking ownership of the object in the hierarchy, so should
sink any floating refs to make it easy to use in C code.
Pavol Klačanský [Wed, 4 Sep 2013 19:00:20 +0000 (21:00 +0200)]
Updated slovak translation
Jasper St. Pierre [Wed, 4 Sep 2013 18:45:01 +0000 (14:45 -0400)]
gdkwindow-x11: Multiply opaque region rects by the window scale
This fixes rendering issues under HiDPI
Alexandre Franke [Wed, 4 Sep 2013 14:44:55 +0000 (16:44 +0200)]
Update French translation
Jasper St. Pierre [Tue, 3 Sep 2013 20:58:12 +0000 (16:58 -0400)]
gdkframeclockidle: Add explicit fallthrough markers
So people reading the code don't get confused.
Jasper St. Pierre [Tue, 3 Sep 2013 20:51:03 +0000 (16:51 -0400)]
accessible: Fix test runner
This was an obvious typo.
Jasper St. Pierre [Tue, 3 Sep 2013 20:47:21 +0000 (16:47 -0400)]
gtkwidget: Fix issues with baseline alignment comparison
Colin Walters [Tue, 3 Sep 2013 21:48:30 +0000 (17:48 -0400)]
build: Fix srcdir != builddir with wayland-client-protocol.h
In the gnome-ostree model builddir contains all generated files not in
git (unless the build system explicitly overrides that). Here the
wayland-client-protocol.h was in $(builddir)/wayland, so we need to
find it using our already extant -I$(top_builddir)/gdk, rather than
relying on same-directory lookup.
Changwoo Ryu [Tue, 3 Sep 2013 16:54:03 +0000 (01:54 +0900)]
Updated Korean translation
Giovanni Campagna [Tue, 3 Sep 2013 09:38:35 +0000 (11:38 +0200)]
wayland: set the wm_class on toplevel windows
Before mapping the window, set the title and class, to allow
application tracking by gnome-shell.
https://bugzilla.gnome.org/show_bug.cgi?id=707129
Giovanni Campagna [Tue, 3 Sep 2013 07:54:53 +0000 (09:54 +0200)]
gtk-shell: extend the protocol with shell capabilities
Add the concept of shell capabilities, which allow the compositor
to advertise support for the app menu and the global menubar,
which are then propagated as GdkSettings.
https://bugzilla.gnome.org/show_bug.cgi?id=707129
Giovanni Campagna [Fri, 30 Aug 2013 11:56:45 +0000 (13:56 +0200)]
wayland: restore support for the application menu
If the compositor supports the gtk-shell interface, use it to
export the application ID, dbus name and paths that can be used
for the application menu.
https://bugzilla.gnome.org/show_bug.cgi?id=707129
Giovanni Campagna [Fri, 30 Aug 2013 11:55:37 +0000 (13:55 +0200)]
wayland: add support for a private gtk-shell protocol
This protocol will be used by mutter-wayland and gtk to replace
the _GTK X11 properties for DBus names/paths.
https://bugzilla.gnome.org/show_bug.cgi?id=707129
Daniel Mustieles [Tue, 3 Sep 2013 14:28:10 +0000 (16:28 +0200)]
Updated Spanish translation
Daniel Mustieles [Tue, 3 Sep 2013 14:21:15 +0000 (16:21 +0200)]
Updated Spanish translation
Matthias Clasen [Mon, 2 Sep 2013 18:51:01 +0000 (14:51 -0400)]
Bump version
Matthias Clasen [Mon, 2 Sep 2013 17:45:59 +0000 (13:45 -0400)]
3.9.14
Gustavo Noronha Silva [Sun, 1 Sep 2013 00:12:09 +0000 (21:12 -0300)]
Bump glib version requirement - GPropertyAction is used on examples
https://bugzilla.gnome.org/show_bug.cgi?id=707201
GunChleoc [Sun, 1 Sep 2013 15:00:31 +0000 (09:00 -0600)]
Added Scottish Gaelic translation
GunChleoc [Sun, 1 Sep 2013 14:58:11 +0000 (08:58 -0600)]
Added Scottish Gaelic translation
Paolo Borelli [Sun, 1 Sep 2013 09:43:05 +0000 (11:43 +0200)]
textview: Use guint since we specify ": 1"
Mike Gorse [Fri, 30 Aug 2013 14:13:39 +0000 (09:13 -0500)]
a11y: Check whether a widget is mapped before querying its parent
Call gtk_widget_get_mapped() in a couple of places before looking at the
widget's parent, since it might be set to a widget that has been
finalized, causing an invalid read.
Cosimo Cecchi [Sun, 25 Aug 2013 03:17:09 +0000 (20:17 -0700)]
pathbar: fix positioning of the down slider button
So that it's always linked with the rest of the pathbar.
https://bugzilla.gnome.org/show_bug.cgi?id=706722
Cosimo Cecchi [Sun, 25 Aug 2013 02:55:23 +0000 (19:55 -0700)]
pathbar: remove unused spacing private member
It's always zero.
https://bugzilla.gnome.org/show_bug.cgi?id=706722
Matthias Clasen [Sat, 31 Aug 2013 21:20:50 +0000 (17:20 -0400)]
GtkPathBar: Don't make current dir bold
This is closer to the nautilus path bar.
https://bugzilla.gnome.org/show_bug.cgi?id=706451
Piotr Drąg [Sat, 31 Aug 2013 21:23:32 +0000 (23:23 +0200)]
Updated Polish translation
Matthias Clasen [Sat, 31 Aug 2013 21:06:44 +0000 (17:06 -0400)]
Fix up a11y tests again
This change was caused by the recently reverted patch.
Matthias Clasen [Sat, 31 Aug 2013 20:16:26 +0000 (16:16 -0400)]
Revert "a11y: Check whether a widget is mapped before querying its parent"
This reverts commit
7e3db6fdd36960fca0ae0e7e078b448b5f8b220a.
It broke the testsuite.
Jasper St. Pierre [Sat, 31 Aug 2013 19:52:56 +0000 (15:52 -0400)]
gtkwindow: Don't set an opaque region if the window is app-paintable
This means the background is effectively unused. This fixes bad drawing
errors with cc-rr-labeller and potentially also notify-osd.
Aleksander Morgado [Sat, 31 Aug 2013 17:58:12 +0000 (13:58 -0400)]
win32: use the input locale to decide the default input method
GTK+ tries to automatically assign the best input module based on the
'system locale'. In the specific case of the IME input method, it will
be the default for the whole GTK+ application if the system locale is
either Japanese (ja), Korean (ko) or Chinese (zh). Other defaults are
equally applicable, e.g. if system locale is Catalan (ca), the special
'Cedilla' input module is chosen.
System locale can be changed (e.g. Win7) through the following sequence
(reboot required):
Control Panel
Region and Language
Administrative
Language for non-Unicode Programs
Change system locale...
The problem with this behaviour is that changing the 'default input
language' (e.g. from English to Japanese+IME) doesn't affect the GTK+
application. Therefore, I can have an English system locale (where GTK+
will choose Simple IM by default) but then have Japanese+IME as input
language.
Default input language can be changed (e.g. Win7) through the following
sequence (no reboot required):
System locale can be changed (e.g. Win7) through:
Control Panel
Region and Language
Keyboards and Languages
Keyboards and other input languages
Change keyboards...
Default input language can also be changed using the language bar directly.
So, instead of using the system-wide default locale to decide which input
method to use as default, better use the input language specified by the
user, which may be the same as the system-wide default locale, or different.
Following the previous example, with an English system locale and a
Japanese+IME input language, the default input method will now be IME
instead of Simple, which is closer to what's expected by the user.
This change only affects the application during startup; i.e. if the user
changes the input language while the application is running, we wouldn't be
changing the default input method to use. We could do this processing the
WM_INPUTLANGCHANGE messages, though.
https://bugzilla.gnome.org/show_bug.cgi?id=700428
Jasper St. Pierre [Sat, 31 Aug 2013 17:21:09 +0000 (13:21 -0400)]
gdkwindow-x11: Correct math for filling in the _NET_WM_OPAQUE_REGION property
This fixes incorrect rendering under mutter and other WMs that implement
_NET_WM_OPAQUE_REGION.
Pavel Vasin [Wed, 21 Aug 2013 11:09:29 +0000 (15:09 +0400)]
GdkWaylandWindow: Fix memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=706493
Pavel Vasin [Wed, 21 Aug 2013 10:59:45 +0000 (14:59 +0400)]
GtkClipboardWayland: Fix memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=706493
Pavel Vasin [Wed, 21 Aug 2013 10:56:21 +0000 (14:56 +0400)]
css shadow: Fix memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=706493
Arnel A. Borja [Mon, 26 Aug 2013 09:52:59 +0000 (17:52 +0800)]
printsettings: Add missing docs for output constants
GTK_PRINT_SETTINGS_OUTPUT_DIR and GTK_PRINT_SETTINGS_OUTPUT_BASENAME
doesn't have documentation.
https://bugzilla.gnome.org/show_bug.cgi?id=706802
Matthias Clasen [Sat, 31 Aug 2013 16:23:54 +0000 (12:23 -0400)]
Fix an age-old typo
GtkIconView was not properly propagating key release events,
since forever.
https://bugzilla.gnome.org/show_bug.cgi?id=706740
Baurzhan Muftakhidinov [Sat, 31 Aug 2013 11:15:18 +0000 (17:15 +0600)]
Update Kazakh translation
Matthias Clasen [Sat, 31 Aug 2013 04:14:58 +0000 (00:14 -0400)]
Revert "Deprecate and ignore gtk-entry-password-hint-timeout"
This reverts commit
4b5a389e88af7e7a1fa9e33294642dcfbc2832ec.
This change caused considerable concern about accidental
leaking of passwords, see e.g.
https://bugzilla.gnome.org/show_bug.cgi?id=706563
https://bugzilla.gnome.org/show_bug.cgi?id=706873
https://bugzilla.redhat.com/show_bug.cgi?id=994237
We may have to do something else for password entries, such
as the windows-style 'peekabo' icon.
Matthias Clasen [Sat, 31 Aug 2013 03:44:04 +0000 (23:44 -0400)]
Don't mark a space as translatable
There is no point in translating a string that consists just
of a single space. Pointed out in
https://bugzilla.gnome.org/show_bug.cgi?id=706778
Seán de Búrca [Sat, 31 Aug 2013 03:03:09 +0000 (21:03 -0600)]
Updated Irish translation
Matthias Clasen [Sat, 31 Aug 2013 02:24:09 +0000 (22:24 -0400)]
Fix up a11y tests for recent changes
The fix for child properties made the a11y dump for the assistant
case change. After close inspection, the new output is what the
code intends to produce, so update the expected result.
Matej Urbančič [Fri, 30 Aug 2013 20:58:15 +0000 (22:58 +0200)]
Updated Slovenian translation
Matej Urbančič [Fri, 30 Aug 2013 20:15:57 +0000 (22:15 +0200)]
Updated Slovenian translation
Matej Urbančič [Fri, 30 Aug 2013 20:15:23 +0000 (22:15 +0200)]
Updated Slovenian translation
Mike Gorse [Fri, 30 Aug 2013 14:13:39 +0000 (09:13 -0500)]
a11y: Check whether a widget is mapped before querying its parent
Call gtk_widget_get_mapped() in a couple of places before looking at the
widget's parent, since it might be set to a widget that has been
finalized, causing an invalid read.
Mike Gorse [Mon, 15 Jul 2013 17:41:56 +0000 (12:41 -0500)]
Don't access memory after freeing it when destroying a tick callback
https://bugzilla.gnome.org/show_bug.cgi?id=704278
Stefano Facchini [Fri, 30 Aug 2013 12:47:17 +0000 (14:47 +0200)]
Christian Hergert [Fri, 30 Aug 2013 07:23:56 +0000 (00:23 -0700)]
wayland: fix crash in gdk_window_wayland_get_root_coords().
Both root_x and root_y may be NULL, so check first before setting.
Chun-wei Fan [Fri, 30 Aug 2013 05:48:12 +0000 (13:48 +0800)]
Update config.h.win32(.in)
Define _GDK_EXTERN more in line with the definition of it on Windows as
defined in configure.ac, and add a MinGW variant for it as well
Seán de Búrca [Fri, 30 Aug 2013 04:36:47 +0000 (22:36 -0600)]
Updated Irish translation
Ek Kato [Thu, 29 Aug 2013 21:12:09 +0000 (14:12 -0700)]
Fix missing return from quartz_filter_keypress
Milo Casagrande [Thu, 29 Aug 2013 16:41:38 +0000 (18:41 +0200)]
[l10n] Updated Italian translation.
Paolo Borelli [Thu, 29 Aug 2013 13:31:01 +0000 (15:31 +0200)]
[headerbar] Do not hardcode title and subtititle style
Let the css theme define them
https://bugzilla.gnome.org/show_bug.cgi?id=707051
Emmanuele Bassi [Wed, 28 Aug 2013 10:48:29 +0000 (11:48 +0100)]
headerbar: Remove hpadding and vpadding properties
We really want these to be set by the theme, not programmatically.
https://bugzilla.gnome.org/show_bug.cgi?id=706929
Stefan Sauer [Thu, 29 Aug 2013 07:06:31 +0000 (09:06 +0200)]
frame: annotate the @label params with (allow-none)
Aurimas Černius [Wed, 28 Aug 2013 19:24:28 +0000 (22:24 +0300)]
Updated Lithuanian translation
Aurimas Černius [Wed, 28 Aug 2013 19:18:48 +0000 (22:18 +0300)]
Updated Lithuanian translation
Emilio Pozuelo Monfort [Tue, 27 Aug 2013 09:30:08 +0000 (11:30 +0200)]
wayland: trust the compositor to always send a good serial number
https://bugzilla.gnome.org/show_bug.cgi?id=706870
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Claudio Saavedra [Wed, 28 Aug 2013 17:10:38 +0000 (20:10 +0300)]
gtkwindow: fix a critical warning
Do not map the title box if it's not visible.
Matthias Clasen [Wed, 28 Aug 2013 15:51:19 +0000 (11:51 -0400)]
Fix a regression in GtkAssistant child property handling
GtkAssistant is bending the rules about child properties
of non-direct children, and the recent fix to accomodate
GtkInfoBar changes broke things. The effect was that child
properties of assistant pages in ui files were just not
applied, so all pages ended up without titles and with
the normal page type, leading to broken assistants all
over the place.
https://bugzilla.gnome.org/show_bug.cgi?id=706756
Jasper St. Pierre [Thu, 22 Aug 2013 17:20:10 +0000 (13:20 -0400)]
gtkwindow: Calculate the opaque window based off of the style
https://bugzilla.gnome.org/show_bug.cgi?id=706922
Jasper St. Pierre [Tue, 14 May 2013 20:23:33 +0000 (16:23 -0400)]
gdk: Add opaque region setters
https://bugzilla.gnome.org/show_bug.cgi?id=706922
Jasper St. Pierre [Tue, 27 Aug 2013 19:35:46 +0000 (15:35 -0400)]
gtkwindow: Consistently set the style classes for window-frame
In one place, we forgot to remove the BACKGROUND style class before
adding window-frame. Add a helper method so these are all the same.
https://bugzilla.gnome.org/show_bug.cgi?id=706922
Stefano Facchini [Tue, 27 Aug 2013 22:13:55 +0000 (00:13 +0200)]
revealer: clamp minimum size to natural one
Instead of just setting them equal.
https://bugzilla.gnome.org/show_bug.cgi?id=706938
Chun-wei Fan [Wed, 28 Aug 2013 06:27:02 +0000 (14:27 +0800)]
MSVC Builds: Fix Build of Introspection Files
We need to copy the GDK .lib/.dll from Release_Broadway\<Platform>\bin
or Debug_Broadway\<Platform>\bin to Release\<Platform>\bin or
Debug\<Platform>\bin respectively during the build of Broadway flavors of
GDK, as the MSVC introspection builds expects the GDK .lib/.dll to be
in Release\<Platform>\bin or Debug\<Platform>\bin.
Use a new property sheet to do so for Broadway builds of GDK-during the
builds of Win32-only GDK, the broadway builds of the GDK .lib/.dll would
be cleared out prior to the build of the Win32-only GDK.
Matthias Clasen [Tue, 27 Aug 2013 16:41:16 +0000 (12:41 -0400)]
Fix anonymous assistants
GtkAssistant supports not showing the sidebar with the page
titles (if the page have no titles). Unfortunately, we were
hiding the sidebar in this case, but still rendering the frame
behind it, leading to a broken appearance.
Kristian Høgsberg [Tue, 27 Aug 2013 14:03:14 +0000 (16:03 +0200)]
clipboard: Fix text mime type handling on Wayland
Benjamin Otte [Tue, 27 Aug 2013 13:59:38 +0000 (15:59 +0200)]
x11: Fix compiler warning
Matthias Clasen [Tue, 27 Aug 2013 03:06:04 +0000 (23:06 -0400)]
Add a test for animated row insertion/removal
This is just a crude example for how to use revealers to
animate insertion and removal of rows in a listbox.
Matthias Clasen [Mon, 26 Aug 2013 03:18:04 +0000 (23:18 -0400)]
Add a way to test titlebars in dark theme
Fran Diéguez [Tue, 27 Aug 2013 01:42:50 +0000 (03:42 +0200)]
Updated Galician translations
Fran Diéguez [Tue, 27 Aug 2013 00:41:18 +0000 (02:41 +0200)]
Updated Galician translations
Seán de Búrca [Mon, 26 Aug 2013 23:50:38 +0000 (17:50 -0600)]
Updated Irish translation
Alexander Larsson [Mon, 26 Aug 2013 19:16:27 +0000 (21:16 +0200)]
GtkTextView: Use *some* extra size for horizontal scrolling
Horizontal scrolling is unusual, but specifying some extra offscreen
space for it in free in the normal case where the viewport is the
same width as the canvas anyway, so lets do it.
Alexander Larsson [Mon, 26 Aug 2013 19:13:05 +0000 (21:13 +0200)]
pixel cache: Allow growing of cache surface
If the new requested surface size is enough larger than the previous
one (but the old is still larger than the absolute minimum),
reallocate it anyway.
This fixes an issue where the text view initially requested a really
small extra size which was then increased but that didn't "take".
Christian Hergert [Sun, 25 Aug 2013 04:35:48 +0000 (21:35 -0700)]
textview: use pixelcache to indirectly renderer to widget.
This patch uses GtkPixelCache to render the contents of the widget,
and typically a bit more, to an offscreen surface. The pixel cache in
turn manages rendering to the actual surface for the widget.
The current strategy for the size to render is the size of the widget
plus half the height.
https://bugzilla.gnome.org/show_bug.cgi?id=701125
Christian Hergert [Sun, 25 Aug 2013 04:08:41 +0000 (21:08 -0700)]
pixelcache: allow specifying content type and extra size.
Allow forcing the cairo_content_t of the surface as well as the
amount of extra size to render.
https://bugzilla.gnome.org/show_bug.cgi?id=706728
Alexander Larsson [Mon, 26 Aug 2013 12:39:50 +0000 (14:39 +0200)]
GdkScreen: Return 1, not 1.0 for the (int) scale factor
Carlos Garcia Campos [Sun, 30 Sep 2012 11:09:53 +0000 (13:09 +0200)]
iconview: Respect the fixed item width when adjusting the wrap width
Restore the code the way it was in GTK2.
https://bugzilla.gnome.org/show_bug.cgi?id=680953
Chun-wei Fan [Mon, 26 Aug 2013 04:12:57 +0000 (12:12 +0800)]
gtk/gtkwindow.c: Fix build on non-X11
There were some code added to this file that is meant for the X11 backend,
but they are being unconditionally built. Add build-time checks for the
X11 backend for these to fix the build on non-X11 platforms.
Kjartan Maraas [Mon, 26 Aug 2013 08:52:11 +0000 (10:52 +0200)]
Updated Norwegian bokmål translation
Seán de Búrca [Mon, 26 Aug 2013 06:20:59 +0000 (00:20 -0600)]
Updated Irish translation
Rafael Ferreira [Mon, 26 Aug 2013 05:54:14 +0000 (02:54 -0300)]
Updated Brazilian Portuguese translation for Gtk+-Properties
Rafael Ferreira [Mon, 26 Aug 2013 05:53:51 +0000 (02:53 -0300)]
Updated Brazilian Portuguese translation for Gtk+-UI